Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Transaction.getChainId when v=27 must return null #2133

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix Transaction.getChainId when v=27 must return null #2133

wants to merge 1 commit into from
+22 −6

Conversation

jpnovais
Copy link

What does this PR do?

fix deriveChainId(long v), when v=27 or v=28 must return null instead of 0, as per EIP155

Where should the reviewer start?

crypto/src/main/java/org/web3j/crypto/TransactionUtils.java#deriveChainId

Why is it needed?

The current seems to be buggy and comply with the EIP155 spec

Checklist

  • I've read the contribution guidelines.
  • I've added tests (if applicable).
  • I've added a changelog entry if necessary.

@jpnovais jpnovais force-pushed the fix-transaction-deriveChainId branch from 8774b65 to 22dd273 Compare December 20, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conor10 conor10 Awaiting requested review from conor10 conor10 is a code owner

@gtebrean gtebrean Awaiting requested review from gtebrean gtebrean is a code owner

@NickSneo NickSneo Awaiting requested review from NickSneo NickSneo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jpnovais